fix(core): Changes to workflow staticData erroneously updating updatedAt #9790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
krynble
previously approved these changes
Jun 18, 2024
packages/cli/test/integration/services/workflowStaticData.service.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/test/integration/services/workflowStaticData.service.test.ts
Outdated
Show resolved
Hide resolved
krynble
approved these changes
Jun 18, 2024
3 flaky tests on run #5579 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Test Replay
Screenshots
Video
|
|
10-undo-redo.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo adding connected nodes |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9790 ↗︎
|
✅ All Cypress E2E specs passed |
…pdated-in-workflows-view-is-wrong
krynble
approved these changes
Jun 18, 2024
|
|
|
✅ All Cypress E2E specs passed |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
Merged
netroy
changed the title
Merged
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When workflow
staticDatawas changed (usually by a trigger node), it'd cause theupdatedAtcolumn to update, even though the workflow hadn't really updated.Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)